feat: Engine Traefik Docker labels for REST API reverse proxy routing #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostbean
approved these changes
Jan 5, 2024
...engine-lib/lib/backend_impls/docker/object_attributes_provider/object_attributes_provider.go
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.0](0.85.56...0.86.0) (2024-01-08) ### ⚠ BREAKING CHANGES * allow to mount multiple artifacts to the same folder in a service. Users will need to replace the `Directory.artifac_name` field key with `Directory.artifac_names` ([#2025](#2025)) * change persistent directory name to deterministic value ([#2006](#2006)) ### Features * allow to mount multiple artifacts to the same folder in a service. Users will need to replace the `Directory.artifac_name` field key with `Directory.artifac_names` ([#2025](#2025)) ([b51df93](b51df93)) * emui design updates ([#2028](#2028)) ([0e480cf](0e480cf)) * Engine Traefik Docker labels for REST API reverse proxy routing ([#2019](#2019)) ([6541884](6541884)) ### Bug Fixes * change persistent directory name to deterministic value ([#2006](#2006)) ([fa08707](fa08707)), closes [#1998](#1998) * log streaming resource leaks ([#2026](#2026)) ([7f8db9b](7f8db9b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Create engine Traefik Docker labels for the REST API port so we can interact with the API via Traefik. The Host header is set to "engine".
Tested with Docker locally:
Is this change user facing?
NO
References (if applicable):
#1970