Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for private registries on docker #2058

Merged
merged 24 commits into from
Jan 22, 2024

Conversation

h4ck3rk3y
Copy link
Contributor

@h4ck3rk3y h4ck3rk3y commented Jan 17, 2024

This adds support for private container registries

TODO

  • add docs
  • cleanup all the nils and maybe make the FetchImage interface nicer
  • perhaps add e2e tests (skipped)

Closes #1342

Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aa6fe30
Status: ✅  Deploy successful!
Preview URL: https://274573e2.kurtosis-docs.pages.dev
Branch Preview URL: https://gyani-private-registries.kurtosis-docs.pages.dev

View logs

@h4ck3rk3y h4ck3rk3y requested a review from tedim52 January 17, 2024 18:41
Copy link
Contributor

@tedim52 tedim52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Jan 22, 2024
Merged via the queue into main with commit 7cda3d0 Jan 22, 2024
38 checks passed
@h4ck3rk3y h4ck3rk3y deleted the gyani/private-registries branch January 22, 2024 13:41
github-merge-queue bot pushed a commit that referenced this pull request Jan 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.86.9](0.86.8...0.86.9)
(2024-01-22)


### Features

* added support for private registries on docker
([#2058](#2058))
([7cda3d0](7cda3d0))
* emui strong indicator for form optional/required
([#2062](#2062))
([f0f51b4](f0f51b4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support private container registries
2 participants