-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add env_vars
as input to run_sh
#2114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with Cloudflare Pages
|
mieubrisse
reviewed
Feb 3, 2024
mieubrisse
approved these changes
Feb 3, 2024
h4ck3rk3y
approved these changes
Feb 5, 2024
h4ck3rk3y
reviewed
Feb 5, 2024
core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_sh.go
Outdated
Show resolved
Hide resolved
internal_testsuites/golang/testsuite/startosis_run_sh_task_test/run_task_sh_task_test.go
Show resolved
Hide resolved
h4ck3rk3y
reviewed
Feb 5, 2024
core/server/api_container/server/startosis_engine/kurtosis_instruction/tasks/run_python.go
Outdated
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 5, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.86.13](0.86.12...0.86.13) (2024-02-05) ### Features * add `env_vars` as input to `run_sh` ([#2114](#2114)) ([5a30ea7](5a30ea7)), closes [#2050](#2050) * add nodejs devtools to Nix ([#2099](#2099)) ([7bbb2bc](7bbb2bc)) * add run docker compose with kurtosis guide ([#2085](#2085)) ([7bbe479](7bbe479)) * Add RunStarlarkScript to enclave manager API ([#2103](#2103)) ([1eeb3eb](1eeb3eb)) ### Bug Fixes * adding the `core script build call`, which was removed by accident, in the main build script ([#2118](#2118)) ([1f73821](1f73821)) * Fix calls to stacktrace in the reverse proxy module ([#2100](#2100)) ([a7fefc2](a7fefc2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]> Co-authored-by: Anders Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change adds
env_vars
to the run_sh. Feature was requested in issue #2050. Example of used in practice:outputs:
Is this change user facing?
YES
References (if applicable):
Closes: #2050