docs: Refactor ServiceConfig to be more informative #2221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5fb53a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://24acc273.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://kevin-service-config-cleanup.kurtosis-docs.pages.dev |
tedim52
approved these changes
Mar 1, 2024
auto-merge was automatically disabled
June 24, 2024 16:09
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our docs are pretty bloated, and our Starlark docs are fairly thrown-together; this is me trying to refine using ServiceConfig (one of our most heavily-used pages) as a v0.
https://www.loom.com/share/b98cb93c9b33472aa21082770c69fe81?sid=6b0fabb4-a206-4f63-8396-9f4726c31f8b
Is this change user facing?
YES