-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set service v0 #2372
Merged
Merged
feat: set service v0 #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h4ck3rk3y
approved these changes
Apr 23, 2024
container-engine-lib/lib/backend_interface/objects/service/service_config.go
Show resolved
Hide resolved
...server/api_container/server/startosis_engine/kurtosis_instruction/add_service/add_service.go
Show resolved
Hide resolved
...server/api_container/server/startosis_engine/kurtosis_instruction/add_service/add_service.go
Outdated
Show resolved
Hide resolved
...server/api_container/server/startosis_engine/kurtosis_instruction/set_service/set_service.go
Show resolved
Hide resolved
...server/api_container/server/startosis_engine/kurtosis_instruction/set_service/set_service.go
Show resolved
Hide resolved
...server/api_container/server/startosis_engine/kurtosis_instruction/set_service/set_service.go
Show resolved
Hide resolved
Deploying kurtosis with Cloudflare Pages
|
This reverts commit 4176358.
This reverts commit 4a7cce8.
tedim52
commented
Apr 25, 2024
...r/server/startosis_engine/interpretation_time_value_store/interpretation_time_value_store.go
Show resolved
Hide resolved
h4ck3rk3y
approved these changes
Apr 25, 2024
core/server/api_container/server/startosis_engine/startosis_interpreter_idempotent_test.go
Show resolved
Hide resolved
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Apr 25, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 27, 2024
🤖 I have created a release *beep* *boop* --- ## [0.88.19](0.88.18...0.88.19) (2024-04-25) ### Features * adding the enclave-db inside the enclave's volume ([#2399](#2399)) ([75805ef](75805ef)) * set service v0 ([#2372](#2372)) ([7056164](7056164)) ### Bug Fixes * typo in clean -a docs ([#2402](#2402)) ([136ec4c](136ec4c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
## Description Adds UI button for setting service image using `set_service` instruction. ![Screen Shot 2024-04-26 at 2 01 06 PM](https://github.com/kurtosis-tech/kurtosis/assets/46531991/8709bdc9-da24-412e-b14c-e366e2630c2c) https://www.loom.com/share/c6e87488214047c782bbffb1d3fa0bb5 ## Is this change user facing? YES ## References #2372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
set_service
instruction which can be used to override the service config of a service added earlier in the plan. This can be really useful for two cases:set_service
to the plan.ex.
set_service
to the plan and enclave editing.ex.
https://www.loom.com/share/f88d0f5555dd49b0aeabc55c5ed41d43
This instruction has some functionality missing such as overriding ports, env vars, and cmd/entrypoint as these require special handling of future references and handling consecutive set service instructions properly but functionality can be added iteratively in future PRs.
Is this change user facing?
YES
References:
#2057