Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding the starlark run repository to maintain this data after an APIC restart #2452

Merged
merged 7 commits into from
May 17, 2024
Merged

feat: adding the starlark run repository to maintain this data after an APIC restart #2452

merged 7 commits into from
May 17, 2024

Conversation

leoporoli
Copy link
Contributor

Description

adding the starlark run repository to have this data after an APIC restart

REMINDER: Tag Reviewers, so they get notified to review

Is this change user facing?

NO

References (if applicable)

@leoporoli leoporoli requested a review from laurentluce May 15, 2024 15:36
@leoporoli leoporoli changed the title feat: adding the starlark run repository to have this data after an APIC restart feat: adding the starlark run repository to mantain this data after an APIC restart May 15, 2024
@leoporoli leoporoli changed the title feat: adding the starlark run repository to mantain this data after an APIC restart feat: adding the starlark run repository to maintain this data after an APIC restart May 15, 2024
@laurentluce
Copy link
Contributor

I will review this change tomorrow. I need a bit more time to ramp-up on the concept of APIC repositories.

laurentluce
laurentluce approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@laurentluce laurentluce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tedim52 Should you take a look since you made some recent changed related to the Starlark run?

core/server/api_container/server/api_container_service.go Outdated Show resolved Hide resolved
@leoporoli leoporoli enabled auto-merge May 16, 2024 14:54
@tedim52
Copy link
Contributor

tedim52 commented May 16, 2024 •
edited
Loading

Hey @leoporoli ! curious, why is the starlark run information required after APIC restart? Do you plan on using it to run the same starlark against an enclave to restart it?

@leoporoli
Copy link
Contributor Author

leoporoli commented May 16, 2024 •
edited
Loading

Hey @leoporoli ! curious, why is the starlark run information required after APIC restart? Do you plan on using it to run the same starlark against an enclave to restart it?

Hey, @tedim52, well I realized that we had to persist it because the enclave list page in the cloud UI is making calls to the GetStarlarkRun endpoint to get the package ID value, so it returns an empty value after an APIC restart.

@leoporoli leoporoli added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@leoporoli leoporoli added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@leoporoli leoporoli added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 7bad2a9 May 17, 2024
52 checks passed
@leoporoli leoporoli deleted the lporoli/starlark-run-repo branch May 17, 2024 12:42
@kurtosisbot kurtosisbot mentioned this pull request May 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 22, 2024
@kurtosisbot
chore(main): release 0.89.11 (#2455)
3476f68 
🤖 I have created a release *beep* *boop*
---


##
[0.89.11](0.89.10...0.89.11)
(2024-05-22)


### Features

* adding the `starlark run` repository to maintain this data after an
APIC restart
([#2452](#2452))
([7bad2a9](7bad2a9))
* display task names in picasso
([#2458](#2458))
([424dc39](424dc39))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <[email protected]>
@kurtosisbot kurtosisbot mentioned this pull request Nov 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentluce laurentluce laurentluce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leoporoli @laurentluce @tedim52