feat: nixify #2461
Open
feat: nixify #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lostbean I would appreciate your review |
marijanp
force-pushed
the
nixify
branch
2 times, most recently
from
6cdc278 to
8b96021
Compare
|
I didn't know that the license was proprietary, so sad. |
Yeah for L1 infrastructure this is kind of ridiculous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Packaged kurtosis with nix.
It's worth mentioning that we tested that the resulting binary works/is used in one of our projects https://github.com/cspr-rad/acropolis
To try it out run, checkout the branch and run
$ nix shell .#kurtosisor (without checking out)
$ nix shell github:kurtosis-tech/kurtosis/nixifyor (once merged)
$ nix shell github:kurtosis-tech/kurtosisREMINDER: Tag Reviewers, so they get notified to review
@lostbean
Is this change user facing?
It is, but it only adds the capability to add kurtosis as a dependency with nix