Add empty columns to chunked node group if needed during COPY #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royi-luo
force-pushed
the
royi/chunked-node-group-subcolumn
branch
from
c2c35b9 to
043ef90
Compare
Benchmark ResultMaster commit hash:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4882 +/- ##
=======================================
Coverage 86.50% 86.51%
=======================================
Files 1403 1403
Lines 60629 60661 +32
Branches 7460 7461 +1
=======================================
+ Hits 52447 52480 +33
+ Misses 8013 8012 -1
Partials 169 169 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
royi-luo
force-pushed
the
royi/chunked-node-group-subcolumn
branch
2 times, most recently
from
6ab993c to
eb895fb
Compare
Benchmark ResultMaster commit hash:
|
royi-luo
changed the title
ray6080
approved these changes
Feb 14, 2025
|
|
||
| for (column_id_t i = 0; i < columnTypes.size(); ++i) { | ||
| if (chunks[i] == nullptr) { | ||
| chunks[i] = std::make_unique<ColumnChunk>(mm, columnTypes[i].copy(), capacity, |
There was a problem hiding this comment.
Can we not set capacity to 0 here for padding chunks?
royi-luo
force-pushed
the
royi/chunked-node-group-subcolumn
branch
from
78c925e to
eba79fa
Compare
Benchmark ResultMaster commit hash:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #4786
After dropping a column (and before checkpointing), if we are directly appending newly-flushed chunked groups to a node group (during copy) the newly inserted node group may not have as many columns as the parent node group, which would cause the next checkpoint to fail.
This PR adds empty columns to the newly inserted node group so that its number of columns is as expected
Also fixes another bug where warning data was being flushed to disk for rel batch insert.
Contributor agreement