Merge pull request #36 from kuzzleio/bugfix

bugfix
kuzzleio · Dec 24, 2015 · 6c4fa5e · 6c4fa5e
2 parents b222adc + f6fe863
commit 6c4fa5e
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 4 deletions.
diff --git a/dist/kuzzle.js b/dist/kuzzle.js
@@ -1273,7 +1273,7 @@ KuzzleDataCollection.prototype.createDocument = function (id, document, options,
     data = {},
     action = 'create';
 
-  if (typeof id !== 'string' && id !== null) {
+  if (id && typeof id !== 'string') {
     cb = options;
     options = document;
     document = id;

diff --git a/dist/kuzzle.min.js b/dist/kuzzle.min.js
diff --git a/dist/kuzzle.min.map b/dist/kuzzle.min.map
diff --git a/src/kuzzleDataCollection.js b/src/kuzzleDataCollection.js
@@ -174,7 +174,7 @@ KuzzleDataCollection.prototype.createDocument = function (id, document, options,
     data = {},
     action = 'create';
 
-  if (typeof id !== 'string' && id !== null) {
+  if (id && typeof id !== 'string') {
     cb = options;
     options = document;
     document = id;

diff --git a/test/kuzzleDataCollection/methods.test.js b/test/kuzzleDataCollection/methods.test.js
@@ -289,6 +289,17 @@ describe('KuzzleDataCollection methods', function () {
       collection.createDocument(null, {}, {}, function () {});
       should(emitted).be.true();
 
+      collection.createDocument(undefined, {});
+      should(emitted).be.true();
+
+      emitted = false;
+      collection.createDocument(undefined, {}, function () {});
+      should(emitted).be.true();
+
+      emitted = false;
+      collection.createDocument(undefined, {}, {}, function () {});
+      should(emitted).be.true();
+
       emitted = false;
       collection.createDocument({}, function () {});
       should(emitted).be.true();