Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports_texture_sample_count method to Metal and Vulkan. #243

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

huacnlee
Copy link
Contributor

@huacnlee huacnlee commented Jan 9, 2025

There need a method to check if the system supports a specific sample count.

Ref zed-industries/zed#22812 need this feature to setup sample_count.

@huacnlee huacnlee changed the title Add supports_texture_sample_count method. Add supports_texture_sample_count method to Metal and Vulkan. Jan 9, 2025
@huacnlee
Copy link
Contributor Author

huacnlee commented Jan 9, 2025

cargo run --example particle

Tested particle example on Windows and macOS, is looks worked will.

@EriKWDev
Copy link
Contributor

EriKWDev commented Jan 9, 2025

Nice addition!

In the particle example, the dropdown for selecting the MSAA count could perhaps use the list of supported formats? Currently hard-coded to:

for i in [1, 2, 4] {
// ...
}

@huacnlee
Copy link
Contributor Author

You're right, I changed it.

Copy link
Owner

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kvark kvark enabled auto-merge (squash) January 10, 2025 05:06
@kvark kvark merged commit b16f5c7 into kvark:main Jan 10, 2025
6 checks passed
@huacnlee huacnlee deleted the add-support-sample-count branch January 10, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants