fix(303): Allow querying viewonly relationships #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The earlier logic did not consider viewonly relationships to build the association tables for the relationships. But it was also not initializing all the necessary variables to be able to query the viewonly relationships. This commit fixes RelationshipBuilder so that the `reflected_relationship` works for viewonly relationships and it does not build anything
|
Hi, when is this planned to be released? Also, what would be the potential workaround for viewonly relationship columns in the current version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier logic did not consider viewonly relationships to build the
association tables for the relationships.
But it was also not initializing all the necessary variables to be able
to query the viewonly relationships.
This commit fixes RelationshipBuilder so that the
reflected_relationshipworks for viewonly relationships and it doesnot build anything