Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kwild setup init should give info on allocs #1258

Closed
brennanjl opened this issue Jan 21, 2025 · 2 comments · Fixed by #1282
Closed

kwild setup init should give info on allocs #1258

brennanjl opened this issue Jan 21, 2025 · 2 comments · Fixed by #1282
Assignees
@charithabandi

Comments

@brennanjl
Copy link
Collaborator

kwild setup init does not say what format inputs to the --allocs flag should be, but it should. This should be done in the command's examples section.
@brennanjl
Copy link
Collaborator Author

Related to this, I am trying to read through the code and realizing that we expect the user to specify the key type as an integer in allocs. Are we certain we want this to be the case?

@jchappelow
Copy link
Member

Related to this, I am trying to read through the code and realizing that we expect the user to specify the key type as an integer in allocs. Are we certain we want this to be the case?

No, this is changing to string in #1254

@charithabandi charithabandi linked a pull request Jan 24, 2025 that will close this issue
Serialization and other minor fixes, updated docs for setup commands #1282
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charithabandi charithabandi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialization and other minor fixes, updated docs for setup commands charithabandi/kwil-db
3 participants
@charithabandi @brennanjl @jchappelow