-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialization and other minor fixes, updated docs for setup commands #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchappelow
reviewed
Jan 23, 2025
This was
linked to
issues
Jan 23, 2025
9324705
to
a327ecf
Compare
a327ecf
to
9597f9b
Compare
jchappelow
reviewed
Jan 24, 2025
jchappelow
reviewed
Jan 24, 2025
jchappelow
reviewed
Jan 24, 2025
jchappelow
reviewed
Jan 24, 2025
jchappelow
previously approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of great changes here! Just a few concerns about the app commands having some implicit coupling and hard to maintain code, but otherwise fine.
Will wait for @jchappelow to confirm |
97d3375
to
8c1a84b
Compare
jchappelow
approved these changes
Jan 27, 2025
Good to merge. Please make a new squashed commit message with the merge. |
8c1a84b
to
44cf9c3
Compare
- Fixes snapshot creation to include all the user datasets and the internal schemas - Updates the snapshot create admin tool to reflect the same for network snapshots - Custom serialization for all the internal resolutions and update the resolution to use ExpiryTimestamp interms of time.Duration rather than blocks - Fixes the alloc initialization issue in the setup commands - Transfer and Balance cli commands assume the secp256k1 keytype by default and the keyType is now an optional field - Leader should be part of the validator set in the genesis config - Mempool won't accept transactions when the node is still in catchup mode - Integration tests now support offline migration
44cf9c3
to
8654a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.