Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization and other minor fixes, updated docs for setup commands #1282

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

charithabandi
Copy link
Contributor

No description provided.

app/setup/genesis.go Outdated Show resolved Hide resolved
app/snapshot/create.go Outdated Show resolved Hide resolved
app/snapshot/create.go Outdated Show resolved Hide resolved
app/snapshot/create.go Outdated Show resolved Hide resolved
jchappelow
jchappelow previously approved these changes Jan 24, 2025
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great changes here! Just a few concerns about the app commands having some implicit coupling and hard to maintain code, but otherwise fine.

@brennanjl
Copy link
Collaborator

Will wait for @jchappelow to confirm

@jchappelow
Copy link
Member

Good to merge. Please make a new squashed commit message with the merge.

- Fixes snapshot creation to include all the user datasets and the internal
  schemas
- Updates the snapshot create admin tool to reflect the same for network
  snapshots
- Custom serialization for all the internal resolutions and update the
  resolution to use ExpiryTimestamp interms of time.Duration rather than blocks
- Fixes the alloc initialization issue in the setup commands
- Transfer and Balance cli commands assume the secp256k1 keytype by default and
  the keyType is now an optional field
- Leader should be part of the validator set in the genesis config
- Mempool won't accept transactions when the node is still in catchup
  mode
- Integration tests now support offline migration
@charithabandi charithabandi merged commit 2c821a2 into kwilteam:main Jan 27, 2025
2 checks passed
@charithabandi charithabandi deleted the setup-tst branch January 27, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants