crypto: testing signature check #1243
Draft
+1,025
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just an FYI, it appears that our personal sign authenticator does not match the previous functionality. Previously, it would ignore the 65th byte (the recovery ID). It no longer does this. This caused the JS SDK to break. I've left this in draft because this was just to diagnose the issue. We can discuss more tomorrow. |
jchappelow
reviewed
Jan 17, 2025
Comment on lines
+72
to
+75
| if signature[ethCrypto.RecoveryIDOffset] == 27 || | ||
| signature[ethCrypto.RecoveryIDOffset] == 28 { | ||
| // Transform yellow paper V from 27/28 to 0/1 | ||
| signature[ethCrypto.RecoveryIDOffset] -= 27 |
There was a problem hiding this comment.
Oh, this is what is missing.
There was a problem hiding this comment.
Although modifying the input slice is probably not good.
There was a problem hiding this comment.
@KwilLuke once you verify that Jon's fix works will you close this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to help luke debug something.
Based on #1231
CC @KwilLuke