Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: added scanning for results #1246

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

core: added scanning for results #1246

wants to merge 5 commits into from

Conversation

brennanjl
Copy link
Collaborator

@brennanjl brennanjl commented Jan 17, 2025

Sorry, I should've split this up into separate PRs. It does 3 things:

  1. It adds the ability to scan into values when using the Go client.
  2. It moves the decimal package into types. It also renames some of the exported functions related to decimals to make it clear that they are for decimals (e.g. NewExplicit -> NewDecimalExplicit). Previously, it was clear that these were for decimals because they were in the decimals package, but now that is not the case.
  3. It renames references to the Kuneiform's decimal type to numeric, to make it match Postgres more closely. This was actually a change I made in the new engine a while ago., there were just a few straggling things I hadn't updated. decimal still works as an alias to numeric.

@brennanjl brennanjl marked this pull request as draft January 17, 2025 18:27
@brennanjl brennanjl marked this pull request as ready for review January 17, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant