node: remove namespace manager Ready() panic #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,8 +55,7 @@ func (n *namespaceManager) Filter(ns string) bool { | |||
| defer n.mu.RUnlock() | |||
|
|
|||
| if !n.ready { | |||
| // this would indicate a bug in our startup process | |||
| panic("namespace manager not ready") | |||
| return false | |||
There was a problem hiding this comment.
I don't think we need this ready field or Ready() method anymore right?
There was a problem hiding this comment.
Yeah we should keep them, because we do not want to return info or kwild_engine as snapshottable schemas if they do not exist
|
Can you approve so I can run main @charithabandi ? |
charithabandi
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes panic on namespace manager