core: gateway response change

[Yaiba]

This update gateway client to be compatible with new kgw repsonse structure, which is compatible with swagger error response

This requires both kwil-cli and kgw update

This should be merged once after kwilteam/kgw#29 is merged

[Yaiba]

All KGW error will be in gatewayErrRespose, this is no use.

[jchappelow]

manually triggered kgw against kgw main test passed: https://github.com/kwilteam/kwil-db/actions/runs/8571353728/job/23491389542 (that doesn't include https://github.com/kwilteam/kgw/pull/29, so is that weird to pass?)

manually triggered kgw against https://github.com/kwilteam/kgw/pull/29 just failed: https://github.com/kwilteam/kwil-db/actions/runs/8571621385 Couldn't find the kgw commit sha? Retry by kgw branch name instead of commit: https://github.com/kwilteam/kwil-db/actions/runs/8571658702/job/23492412534 looks to be running

[Yaiba]

For test on main, I guess not, because we don't really test the error for KGW APIs?

For test on kwilteam/kgw#29, not sure

[jchappelow]

Confirmed this matches kgw ResponseError: https://github.com/kwilteam/kgw/pull/29/files#diff-7ed3dcaadf0b52ddf9731d830f75cdec87978777990f6a397d5a2beb6ad6975bR27-R29

and kgw marshals that type for errors in https://github.com/kwilteam/kgw/pull/29/files#diff-8b7f25bac2ae04c2ce2abb628c6aa28103fd113103a62f3e9d232fa995684915R67

✔️

[jchappelow]

https://github.com/kwilteam/kgw/pull/29 is merged. I think kgw repo should have a replace for the core module (a commit on main) so that it uses this when it's merged.

[jchappelow]

Or kgw update require to a pseudoversion of core

[jchappelow]

Hmm, the kgw manual test run against kgw main and kwil-db main (without this PR) passed. https://github.com/kwilteam/kwil-db/actions/runs/8571925077/job/23493296723
Is that expected without these payload changes.

Anyway, this PR LGTM.

[Yaiba]

kwilteam/kgw#29 is merged. I think kgw repo should have a replace for the core module (a commit on main) so that it uses this when it's merged.

You mean for testing? In the workflow, if the branch is not 'release-*', it'll use 'go work', so it will use the core moudle(commin on 'main') on kwil-db

[Yaiba]

Hmm, the kgw manual test run against kgw main and kwil-db main (without this PR) passed. https://github.com/kwilteam/kwil-db/actions/runs/8571925077/job/23493296723 Is that expected without these payload changes.

Anyway, this PR LGTM.

yeah that's what I mentioned on the meeting, I didn't create a test on this error response case

[jchappelow]

kwilteam/kgw#29 is merged. I think kgw repo should have a replace for the core module (a commit on main) so that it uses this when it's merged.

You mean for testing? In the workflow, if the branch is not 'release-*', it'll use 'go work', so it will use the core moudle(commin on 'main') on kwil-db

No, just for kgw build. The go.mod in the kgw repo does not have a replace or anything that would have it use latest kwil-db. We have to update it for every change to core that we want kgw to use.

[Yaiba]

kwilteam/kgw#29 is merged. I think kgw repo should have a replace for the core module (a commit on main) so that it uses this when it's merged.

You mean for testing? In the workflow, if the branch is not 'release-*', it'll use 'go work', so it will use the core moudle(commin on 'main') on kwil-db

No, just for kgw build. The go.mod in the kgw repo does not have a replace or anything that would have it use latest kwil-db. We have to update it for every change to core that we want kgw to use.

For local dev I also use 'go work', so it's not a problem? I don't think I get you

[jchappelow]

Ah, sorry sorry, I see in .github/workflows/kgw-test-reuse.yaml: go work use . $kdbDir/core

[Yaiba]

Ah, sorry sorry, I see in .github/workflows/kgw-test-reuse.yaml: go work use . $kdbDir/core

yeah, I think that will serve the purpose