Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip CI on some file changes #712

Merged
merged 3 commits into from
May 10, 2024
Merged

skip CI on some file changes #712

merged 3 commits into from
May 10, 2024

Conversation

Yaiba
Copy link
Contributor

@Yaiba Yaiba commented May 9, 2024

As our CI running time is now taking average 25 mins, we need to offload some unnecessary CI runs.

This add path filter to skip CI on certain file changes.

We use https://github.com/dorny/paths-filter, as the builtin path filter won't fit in our use case

@Yaiba Yaiba changed the title Ci/try not to run skip CI on some file changes May 9, 2024
@Yaiba Yaiba force-pushed the ci/try-not-to-run branch from 77c0841 to 177f77e Compare May 9, 2024 23:00
@Yaiba Yaiba force-pushed the ci/try-not-to-run branch from 6f92e05 to feb5fd4 Compare May 10, 2024 16:35
@Yaiba
Copy link
Contributor Author

Yaiba commented May 10, 2024

I also modified CI so only 'jsonrpc,cli' drivers are run for PR, http driver will be run after merged, that will save us about 5-10 mins on every CI run

I think it's good to go.

@Yaiba Yaiba requested review from brennanjl and jchappelow and removed request for brennanjl May 10, 2024 19:15
@Yaiba Yaiba added this to the v0.8.0 milestone May 10, 2024
@Yaiba Yaiba force-pushed the ci/try-not-to-run branch from bf8fc54 to 120cd94 Compare May 10, 2024 20:54
Copy link
Collaborator

@brennanjl brennanjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this

@Yaiba Yaiba merged commit d7ffcba into kwilteam:main May 10, 2024
2 checks passed
charithabandi pushed a commit that referenced this pull request May 10, 2024
* skip running CI on files
* disable http driver for CI workflow, enable it for main workflow
* CI: backport condition change
charithabandi pushed a commit that referenced this pull request May 10, 2024
* skip running CI on files
* disable http driver for CI workflow, enable it for main workflow
* CI: backport condition change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants