Fix German negative numbers (#172)

kwn · Feb 24, 2024 · 0b29195 · 0b29195
1 parent bf8e9d9
commit 0b29195
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -71,5 +71,5 @@ workflows:
           name: build-php-<< matrix.php_version >>
           matrix:
             parameters:
-              php_version: ["8.0", "8.1", "8.2"]
+              php_version: ["8.0", "8.1", "8.2", "8.3"]
               xdebug_version: ["stable"]
diff --git a/src/Language/German/GermanDictionary.php b/src/Language/German/GermanDictionary.php
@@ -124,7 +124,7 @@ class GermanDictionary implements Dictionary
 
     public function getMinus(): string
     {
-        return 'Minus';
+        return 'minus';
     }
 
     public function getZero(): string

diff --git a/src/NumberTransformer/GenericNumberTransformer.php b/src/NumberTransformer/GenericNumberTransformer.php
@@ -27,17 +27,18 @@ public function toWords(int $number): string
         }
 
         $words = [];
+        $minus = '';
 
         if ($number < 0) {
-            $words[] = $this->dictionary->getMinus();
+            $minus = $this->dictionary->getMinus();
             $number *= -1;
         }
 
         if (null !== $this->tripletTransformer || null !== $this->powerAwareTripletTransformer) {
             $words = array_merge($words, $this->getWordsBySplittingIntoTriplets($number));
         }
 
-        return trim(implode($this->wordsSeparator, $words));
+        return trim(sprintf('%s %s', $minus, implode($this->wordsSeparator, $words)));
     }
 
     private function getWordsBySplittingIntoTriplets(int $number): array

diff --git a/tests/NumberTransformer/GermanNumberTransformerTest.php b/tests/NumberTransformer/GermanNumberTransformerTest.php
@@ -12,6 +12,8 @@ protected function setUp(): void
     public function providerItConvertsNumbersToWords(): array
     {
         return [
+            [-287, 'minus zweihundertsiebenundachtzig'],
+            [-10, 'minus zehn'],
             [0, 'null'],
             [1, 'eins'],
             [2, 'zwei'],