Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Rewrite user configuration. #296

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat!: Rewrite user configuration. #296

wants to merge 1 commit into from

Conversation

kylechui
Copy link
Owner

@kylechui kylechui commented Jan 15, 2024

BREAKING CHANGE

This commit will deprecate the existing setup and buffer_setup function calls, in line with this blog post. I believe that plugins, by default, should merely expose functionality but not actively modify user configuration at all. The goal is to have the installation script in the README contain the current "default" configuration, and any changes can be made by users directly. While this results in more code for the end user, I think that the reduced complexity and layers of abstraction will ultimately help users better understand the plugin and have more control for how it behaves.

The changes will be:

  • setup(...)vim.g.nvim_surround
  • buffer_setup(...)vim.b.nvim_surround

@bew
Copy link
Contributor

bew commented Sep 27, 2024

👍
Does that mean that we could theoretically dynamically add/remove surrounds that will then be available when triggering surround actions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants