Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed character warning for Swift 3.2, Swift 4.0 & Swift 4.2 #42

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

stefanrenne
Copy link
Contributor

@stefanrenne stefanrenne commented Dec 4, 2017

Fixed character warning for Swift 3.2, Swift 4.0 & Swift 4.2

@stefanrenne
Copy link
Contributor Author

@kylef please review and merge

@rwgrier
Copy link

rwgrier commented Feb 20, 2018

@kylef Mind reviewing this PR and getting it merged in? Would love to get these warnings taken care of in a project I'm using this in.

Thanks!

@shams-ahmed
Copy link

@kylef Any chance this can be merged and shipped?

I wonder if it easier to get people from the community to have write access to help push this project forward?

@stefanrenne
Copy link
Contributor Author

stefanrenne commented Mar 26, 2018

@shams-ahmed I know, it's frustrating that @kylef hasn't even looked at this for 4 months. I even tried mailing and tweeting him but again no response.

If your using cocoapods then you can use my fix like this:

pod 'URITemplate', :git => 'https://github.com/stefanrenne/URITemplate.swift', :commit => '62608fc890998555f2cf3f22d423d8073f1b020f'

@flockoffiles
Copy link

Any progress on getting this merged?

@stefanrenne
Copy link
Contributor Author

@flockoffiles nope, @kylef isn't responding to any of my messages.

@flockoffiles
Copy link

@stefanrenne, oh, that's unfortunate... I wonder if this repository will be maintained any further...

@rwgrier
Copy link

rwgrier commented May 23, 2018

Based on Kyle's comments here: kylef/Mockingjay#98, it sounds like he won't have the time to continue with MockingJay. I suspect the same applies to this project too.

@ConEliopoulos
Copy link

If you aren't concerned about supporting Swift 3 there is always this SwiftScream/URITemplate

@dominik-hadl
Copy link

@kylef Can we just merge this? The point of PRs is that you don't have to spend time fixing things, as others will fix them for you - so especially for a simple fix like this, I can't imagine it taking longer than 2 minutes of your time.

@stefanrenne stefanrenne changed the title Fixed character warning for Swift 3.2 & Swift 4 Fixed character warning for Swift 3.2, Swift 4 & Swift 4.2 Sep 3, 2018
@stefanrenne
Copy link
Contributor Author

Just tested this PR in the new xCode beta with Swift 4.2 and this PR resolved all Swift 4.2 errors. @kylef please review.

@stefanrenne stefanrenne changed the title Fixed character warning for Swift 3.2, Swift 4 & Swift 4.2 Fixed character warning for Swift 3.2, Swift 4.0 & Swift 4.2 Sep 3, 2018
@kylef kylef merged commit 9f2a9da into kylef:master Mar 25, 2019
@stefanrenne stefanrenne deleted the feature/Swift-3.2-warnings branch March 25, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants