-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed character warning for Swift 3.2, Swift 4.0 & Swift 4.2 #42
Conversation
@kylef please review and merge |
@kylef Mind reviewing this PR and getting it merged in? Would love to get these warnings taken care of in a project I'm using this in. Thanks! |
@kylef Any chance this can be merged and shipped? I wonder if it easier to get people from the community to have write access to help push this project forward? |
@shams-ahmed I know, it's frustrating that @kylef hasn't even looked at this for 4 months. I even tried mailing and tweeting him but again no response. If your using cocoapods then you can use my fix like this:
|
Any progress on getting this merged? |
@flockoffiles nope, @kylef isn't responding to any of my messages. |
@stefanrenne, oh, that's unfortunate... I wonder if this repository will be maintained any further... |
Based on Kyle's comments here: kylef/Mockingjay#98, it sounds like he won't have the time to continue with MockingJay. I suspect the same applies to this project too. |
If you aren't concerned about supporting Swift 3 there is always this SwiftScream/URITemplate |
@kylef Can we just merge this? The point of PRs is that you don't have to spend time fixing things, as others will fix them for you - so especially for a simple fix like this, I can't imagine it taking longer than 2 minutes of your time. |
Just tested this PR in the new xCode beta with Swift 4.2 and this PR resolved all Swift 4.2 errors. @kylef please review. |
Fixed character warning for Swift 3.2, Swift 4.0 & Swift 4.2