Skip to content

Commit

Permalink
bug: always run status action (#1440)
Browse files Browse the repository at this point in the history
/kind bug
/area ci

Seems that when previous job fails, status job gets skipped, resulting in letting PR merge. Try to always run the job regardless the result of previous dependant jobs.
  • Loading branch information
Ressetkk authored Nov 8, 2024
1 parent 766a03f commit 8f7bfab
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions .github/workflows/pull-request-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
pull-request-status:
needs: [ build-image, unit-tests, integration-tests, ui-tests, verify-pins ]
runs-on: ubuntu-latest
if: always()
steps:
- if: ${{ !(contains(needs.*.result, 'failure')) }}
run: exit 0
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ jobs:
pull-request-status:
needs: [ build-image, unit-tests, integration-tests, ui-tests, verify-pins ]
runs-on: ubuntu-latest
if: always()
steps:
- if: ${{ !(contains(needs.*.result, 'failure')) }}
run: exit 0
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/ui-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: tj-actions/changed-files@e9772d140489982e0e3704fea5ee93d536f1e275
id: changed-files
with:
Expand Down

0 comments on commit 8f7bfab

Please sign in to comment.