Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIRule reconcile function refactoring #1016

Closed
8 tasks done
Tracked by #939
strekm opened this issue Apr 25, 2024 · 0 comments
Closed
8 tasks done
Tracked by #939

APIRule reconcile function refactoring #1016

strekm opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@strekm
Copy link
Contributor

strekm commented Apr 25, 2024

Description

Introduction of APIRule v2alpha1 added complexity to main reconcile function that needs to be addressed before adding extAuth handler.

ACs:

  • removed complexity from reconcile function
  • make implementation easy to extend with another handler
  • make reconcile function version aware
  • Create follow up issues

Additional info

  • Configuration for immutable fields can be achieved by using CEL validation:
    // +kubebuilder:validation:XValidation:rule="self == oldSelf",message="Value is immutable"
    This might be useful to support conversion from v1beta2 to 1 without need for preserveUnknownFields.

DoD:

  • Provide unit and integration tests. -> integration tests in follow up, but also migration integration tests exist that cover the implementation.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
    - [ ] If you changed the resource limits, explain why it was needed.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
    => code coverage decreased from 61,1% to 59,2% but this is also due to open todos like for v2alpha1 validation, because some of the code already exists to match the interfaces, but the real implementation and tests will be done in a follow up.
    - [ ] Add release notes.

Attachments
part of: #939

PR

Follow ups

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. area/api-gateway Issues or PRs related to api-gateway labels Apr 25, 2024
@strekm strekm mentioned this issue Apr 25, 2024
18 tasks
@barchw barchw self-assigned this Jun 24, 2024
@triffer triffer self-assigned this Jul 2, 2024
@strekm strekm added this to the 2.4.0 milestone Jul 10, 2024
@strekm strekm closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants