Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor APIRule reconciliation loop #1140

Merged
merged 19 commits into from
Jul 9, 2024
Merged

Refactor APIRule reconciliation loop #1140

merged 19 commits into from
Jul 9, 2024

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Jul 2, 2024 •
edited by triffer
Loading

Description

Changes proposed in this pull request:

  • Separate the v2alpha1 loop from v1beta1

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Jul 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 2, 2024
triffer
triffer reviewed Jul 3, 2024
View reviewed changes
internal/processing/status/status.go Outdated Show resolved Hide resolved
internal/processing/status/status.go Outdated Show resolved Hide resolved
internal/processing/status/v1beta1/v1beta1.go Outdated Show resolved Hide resolved
internal/validation/v1beta1/v1beta1.go Outdated Show resolved Hide resolved
@triffer triffer self-requested a review July 4, 2024 13:23
@triffer triffer marked this pull request as ready for review July 8, 2024 08:28
@triffer triffer requested a review from a team as a code owner July 8, 2024 08:28
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2024
@triffer triffer requested a review from a team as a code owner July 8, 2024 10:12
@barchw barchw mentioned this pull request Jul 8, 2024
Closed
8 tasks
triffer
triffer previously approved these changes Jul 8, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 8, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 8, 2024
@triffer triffer self-requested a review July 9, 2024 05:16
triffer
triffer previously approved these changes Jul 9, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 9, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 9, 2024
@triffer triffer requested review from nataliasitko and triffer July 9, 2024 07:43
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 9, 2024
@kyma-bot kyma-bot merged commit 33fcdc2 into kyma-project:main Jul 9, 2024
16 checks passed
@barchw barchw deleted the refactor branch July 19, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

@triffer triffer triffer approved these changes

Assignees

@triffer triffer

@nataliasitko nataliasitko

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barchw @kyma-bot @triffer @nataliasitko