Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add proper categories for CRDs #1337

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Conversation

a-thaler
Copy link
Contributor

@a-thaler a-thaler commented Oct 1, 2024

Description

Changes proposed in this pull request:

  • Add proper categories for telemetry CRDs according to linked ADR

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@a-thaler a-thaler requested a review from a team as a code owner October 1, 2024 16:46
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Oct 1, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
@kolodziejczak kolodziejczak added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 4, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
@kyma-bot kyma-bot merged commit c90a235 into kyma-project:main Oct 4, 2024
23 checks passed
@a-thaler a-thaler deleted the categories branch October 7, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants