Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate main and release images #1434

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Ressetkk
Copy link
Collaborator

@Ressetkk Ressetkk commented Nov 7, 2024

/kind chore
/area ci

Separate images that we run on main/releases/pr in order to keep better isolation between the artifacts to allow introducing registry automations.

#1234

@Ressetkk Ressetkk requested a review from a team as a code owner November 7, 2024 15:06
@kyma-bot kyma-bot added kind/chore Categorizes issue or PR as related to a chore. area/ci Issues or PRs related to CI related topics labels Nov 7, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2024
Copy link
Collaborator

@triffer triffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to change those images:

docker pull europe-docker.pkg.dev/kyma-project/prod/api-gateway-manager:"${{ needs.get-sha.outputs.sha }}"

/kind chore
/area ci

Separate images that we run on main/releases/pr in order to keep better isolation between the artifacts to allow introducing registry automations.
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 13, 2024
@Ressetkk Ressetkk merged commit dcd2fbe into kyma-project:main Nov 13, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. kind/chore Categorizes issue or PR as related to a chore. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants