-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: separate main and release images #1434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
kind/chore
Categorizes issue or PR as related to a chore.
area/ci
Issues or PRs related to CI related topics
labels
Nov 7, 2024
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 7, 2024
Ressetkk
force-pushed
the
chore/image-separation
branch
from
November 7, 2024 15:07
c1d1c36
to
25715fe
Compare
Ressetkk
force-pushed
the
chore/image-separation
branch
from
November 8, 2024 08:36
25715fe
to
0d68586
Compare
Ressetkk
force-pushed
the
chore/image-separation
branch
from
November 8, 2024 12:42
0d68586
to
f58765a
Compare
Ressetkk
force-pushed
the
chore/image-separation
branch
from
November 12, 2024 15:07
f58765a
to
c634993
Compare
triffer
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to change those images:
docker pull europe-docker.pkg.dev/kyma-project/prod/api-gateway-manager:"${{ needs.get-sha.outputs.sha }}" |
Ressetkk
force-pushed
the
chore/image-separation
branch
from
November 13, 2024 09:34
c634993
to
6c53050
Compare
/kind chore /area ci Separate images that we run on main/releases/pr in order to keep better isolation between the artifacts to allow introducing registry automations.
Ressetkk
force-pushed
the
chore/image-separation
branch
from
November 13, 2024 09:49
6c53050
to
ecc3c15
Compare
triffer
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/ci
Issues or PRs related to CI related topics
cla: yes
Indicates the PR's author has signed the CLA.
kind/chore
Categorizes issue or PR as related to a chore.
lgtm
Looks good to me!
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind chore
/area ci
Separate images that we run on main/releases/pr in order to keep better isolation between the artifacts to allow introducing registry automations.
#1234