Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CRA migration permissions #215

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Remove CRA migration permissions #215

merged 2 commits into from
Apr 9, 2024

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Mar 26, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Remove permissions only used for migrations
  • Bump image, removing migration code

Related issue(s)

kyma-project/kyma#18628

@VOID404 VOID404 requested a review from a team as a code owner March 26, 2024 11:26
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2024
@VOID404 VOID404 mentioned this pull request Mar 26, 2024
Closed
15 tasks
koala7659
koala7659 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 27, 2024
koala7659
koala7659 requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update compass runtime agent image

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 27, 2024
@koala7659
Copy link
Contributor

/test all

@Disper Disper mentioned this pull request Apr 4, 2024
Closed
@Disper Disper requested a review from akgalwas April 8, 2024 07:45
@VOID404 VOID404 requested a review from koala7659 April 9, 2024 08:44
koala7659
koala7659 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 9, 2024
@VOID404 VOID404 merged commit 0338c4b into kyma-project:main Apr 9, 2024
8 of 10 checks passed
@VOID404 VOID404 deleted the remove-cra-migration branch September 5, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koala7659 koala7659 koala7659 approved these changes

@akgalwas akgalwas Awaiting requested review from akgalwas

Assignees

@akgalwas akgalwas

@koala7659 koala7659

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VOID404 @koala7659 @akgalwas @kyma-bot