Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Manager client #674

Merged
merged 15 commits into from
May 15, 2024

Conversation

szwedm
Copy link
Contributor

@szwedm szwedm commented Apr 23, 2024

Description

Add Service Manager client built from available credentials stored in SAP BTP service operator secrets. Client is required for operations on Service Offerings, Service Instances and Service Bindings.

Related issue(s)

See #442

@szwedm szwedm requested a review from a team as a code owner April 23, 2024 05:45
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2024
@szwedm
Copy link
Contributor Author

szwedm commented Apr 23, 2024

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2024
@szwedm szwedm force-pushed the service-manager-client branch 2 times, most recently from 053083f to 1ce7f42 Compare April 23, 2024 07:55
@szwedm szwedm marked this pull request as draft April 23, 2024 09:53
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
@szwedm szwedm force-pushed the sm-integration branch 2 times, most recently from 1c0def7 to e078a3e Compare April 26, 2024 09:39
@kyma-gopher-bot kyma-gopher-bot force-pushed the sm-integration branch 2 times, most recently from b8b6e5b to 38e9d90 Compare May 9, 2024 08:54
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2024
@szwedm szwedm force-pushed the service-manager-client branch 2 times, most recently from 718d203 to 88b58f5 Compare May 9, 2024 11:23
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 9, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2024
@szwedm szwedm marked this pull request as ready for review May 15, 2024 12:07
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@szwedm
Copy link
Contributor Author

szwedm commented May 15, 2024

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label May 15, 2024
@szwedm
Copy link
Contributor Author

szwedm commented May 15, 2024

/test pull-btp-manager-build

@szwedm szwedm merged commit 0e8db25 into kyma-project:sm-integration May 15, 2024
14 checks passed
@szwedm szwedm self-assigned this May 16, 2024
szwedm added a commit that referenced this pull request May 28, 2024
* Add SM client

* Get secret for SM http client

* Build HTTP client for Service Manager

* Add method to fetch service offerings

* Add method to fetch service offerings

* Add Common struct with fields common to all SM objects

* Add ServiceOffering struct

* Add method to extract ServiceOffering metadata fields values

* Adjustments for running in main

* nil checks and log improvements

* Add method for setting client for given secret

* Fix not found error return

* Fix tests after adding ServiceInstance CRD existence check

* go mod tidy and goimports

* Handle k8s not found error when default secret does not exist
szwedm added a commit that referenced this pull request Aug 21, 2024
* Add SM client

* Get secret for SM http client

* Build HTTP client for Service Manager

* Add method to fetch service offerings

* Add method to fetch service offerings

* Add Common struct with fields common to all SM objects

* Add ServiceOffering struct

* Add method to extract ServiceOffering metadata fields values

* Adjustments for running in main

* nil checks and log improvements

* Add method for setting client for given secret

* Fix not found error return

* Fix tests after adding ServiceInstance CRD existence check

* go mod tidy and goimports

* Handle k8s not found error when default secret does not exist
kyma-gopher-bot pushed a commit that referenced this pull request Aug 22, 2024
* Add SM client

* Get secret for SM http client

* Build HTTP client for Service Manager

* Add method to fetch service offerings

* Add method to fetch service offerings

* Add Common struct with fields common to all SM objects

* Add ServiceOffering struct

* Add method to extract ServiceOffering metadata fields values

* Adjustments for running in main

* nil checks and log improvements

* Add method for setting client for given secret

* Fix not found error return

* Fix tests after adding ServiceInstance CRD existence check

* go mod tidy and goimports

* Handle k8s not found error when default secret does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants