Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the docs on creating Secrets #883

Merged
merged 12 commits into from
Oct 17, 2024
Merged

Improve the docs on creating Secrets #883

merged 12 commits into from
Oct 17, 2024

Conversation

IwonaLanger
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add "Create a Service Instance with a Namespace-Based Secret"
  • Enhance "Create a Service Instance with a Custom Secret"
  • Add the diagram of Secrets Precedence
  • Move task docs to the user folder
  • Minor fixes

Related issue(s)
#5875

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. labels Oct 10, 2024
@github-actions GitHub Actions
Copy link

Add one of following labels

- kind/feature -> Use it when you want to submit a new feature

- kind/enhancement -> Use it when you modify or improve an existing feature

- kind/bug -> Use it when you fix a bug

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2024
@IwonaLanger IwonaLanger added the kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature label Oct 10, 2024
@IwonaLanger IwonaLanger self-assigned this Oct 10, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 11, 2024
@IwonaLanger IwonaLanger marked this pull request as ready for review October 14, 2024 10:19
@IwonaLanger IwonaLanger requested review from a team as code owners October 14, 2024 10:19
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2024
@kyma-gopher-bot kyma-gopher-bot enabled auto-merge (squash) October 14, 2024 10:19
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 16, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 17, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@IwonaLanger IwonaLanger added the lgtm Looks good to me! label Oct 17, 2024
@kyma-gopher-bot kyma-gopher-bot merged commit a05f80c into kyma-project:main Oct 17, 2024
18 checks passed
@IwonaLanger IwonaLanger deleted the fixes_and_improvements branch October 17, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grego952 grego952 grego952 approved these changes

@jaroslaw-pieszka jaroslaw-pieszka jaroslaw-pieszka approved these changes

Assignees

@jaroslaw-pieszka jaroslaw-pieszka

@grego952 grego952

@IwonaLanger IwonaLanger

Labels
area/documentation Issues or PRs related to documentation cla: yes Indicates the PR's author has signed the CLA. kind/enhancement Categorizes issue or PR as related to modifying or improving an existing feature lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IwonaLanger @kyma-bot @jaroslaw-pieszka @grego952 @kyma-gopher-bot