fix extensibility badges #2694
Merged
fix extensibility badges #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
the
size/M
mrCherry97
requested review from
NHingerl,
grego952,
IwonaLanger,
nataliasitko,
mmitoraj,
akucharska and
valentinvieriu
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
kyma-bot
added
size/L
grego952
previously approved these changes
Dec 15, 2023
chriskari
reviewed
Dec 15, 2023
chriskari
previously approved these changes
Dec 15, 2023
akucharska
requested changes
Dec 15, 2023
There was a problem hiding this comment.
Change also in:
- examples/injections/apirules.yaml
- examples/services/configuration.yaml
- src/components/Extensibility/components/tests/Badge.test.js
- tests/integration/fixtures/examples/injections/apirules.yaml
- tests/integration/fixtures/examples/services/configuration.yaml
| - rendered as warning: `unknown`, `warning`. | ||
| - rendered as error: `error`, `failure`, `invalid`. | ||
| - rendered as critical: `error`, `failure`, `invalid`. |
There was a problem hiding this comment.
Change also in examples, line 233 and 837
|
@mrCherry97: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
akucharska
approved these changes
Dec 18, 2023
grego952
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)