Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show tooltip on defined widget #3071

Merged
merged 8 commits into from
Jul 23, 2024
Merged

fix: Show tooltip on defined widget #3071

merged 8 commits into from
Jul 23, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Jul 17, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Show tooltip on widget specified in extensibility form
  • Show tooltip on not specified widget in form
  • Fix tooltip ids to be unique
  • Add documentation about how to remove tooltip

Related issue(s)

#2893

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@dbadura dbadura changed the title Show tooltip on defined widget fix: Show tooltip on defined widget Jul 17, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2024
@dbadura
Copy link
Contributor Author

dbadura commented Jul 17, 2024

/retest

@mrCherry97
Copy link
Contributor

mrCherry97 commented Jul 18, 2024 •
edited by dbadura
Loading

  • add displaying tooltips from CRDs in "normal" views (example: Deployments, CronJobs)
  • checks id's to open only one tooltip
  • Try to have the link working (stretch)
  • add information in docs about overriding description, and information about default description taken from CRD

@dbadura dbadura force-pushed the show-tooltip-extensibility branch from 84e58f2 to a2c7750 Compare July 19, 2024 07:38
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 19, 2024
@dbadura dbadura requested a review from a team as a code owner July 19, 2024 08:43
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 19, 2024
@dbadura dbadura force-pushed the show-tooltip-extensibility branch from c64c186 to 820358b Compare July 19, 2024 09:08
@dbadura dbadura force-pushed the show-tooltip-extensibility branch from 820358b to 9d93d8d Compare July 19, 2024 09:11
@dbadura dbadura linked an issue Jul 19, 2024 that may be closed by this pull request
Allow adding description for widget FormGroup #2893
Closed
akucharska
akucharska previously approved these changes Jul 22, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 22, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 22, 2024
@kyma-bot kyma-bot merged commit 4d830bd into kyma-project:main Jul 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitoraj mmitoraj mmitoraj approved these changes

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@valentinvieriu valentinvieriu Awaiting requested review from valentinvieriu

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

@mmitoraj mmitoraj

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow adding description for widget FormGroup
5 participants
@dbadura @mrCherry97 @akucharska @mmitoraj @kyma-bot