Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dynamic config #3312

Merged
merged 7 commits into from
Sep 3, 2024
Merged

feat: Dynamic config #3312

merged 7 commits into from
Sep 3, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Aug 28, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • add env file to choose which configuration to load at busola startup

Related issue(s)

#3299

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2024
@dbadura dbadura marked this pull request as ready for review August 28, 2024 20:16
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2024
@dbadura dbadura linked an issue Aug 28, 2024 that may be closed by this pull request
Configure busola to use different configuration #3299
Closed
mrCherry97
mrCherry97 reviewed Sep 2, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, probably we need to move a little bit more forward to see more value

@dbadura dbadura changed the title Dynamic config feat: Dynamic config Sep 2, 2024
akucharska
akucharska reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 3, 2024
@akucharska akucharska merged commit 8267ba2 into kyma-project:main Sep 3, 2024
54 of 55 checks passed
@dbadura dbadura deleted the dynamic-config branch September 3, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrCherry97 mrCherry97 mrCherry97 left review comments

@akucharska akucharska akucharska approved these changes

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

@mrCherry97 mrCherry97

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure busola to use different configuration
4 participants
@dbadura @kyma-bot @akucharska @mrCherry97