feat: Enhance PVC #3319
Merged
feat: Enhance PVC #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
kyma-bot
added
cla: yes
kyma-bot
added
size/L
mrCherry97
requested review from
a team,
akucharska,
chriskari and
OliwiaGowor
as code owners
kyma-bot
removed
the
do-not-merge/work-in-progress
58 tasks
OliwiaGowor
reviewed
Sep 3, 2024
| value: pvc => | ||
| pvc.status.capacity ? ( | ||
| Object.entries(pvc?.status?.capacity).map(capacity => { | ||
| console.log(capacity); |
Comment on lines
+219
to
+223
| <LayoutPanelRow | ||
| name={capacity[0]} | ||
| value={capacity[1] || EMPTY_TEXT_PLACEHOLDER} | ||
| key={capacity[0]} | ||
| /> |
There was a problem hiding this comment.
possibly change it to new long columns
#3324
public/i18n/en.yaml
Outdated
| @@ -1108,13 +1108,17 @@ nodes: | |||
| persistent-volume-claims: | |||
| description: <0>PersistentVolumeClaim (PVC)</0> is a request for the PersistentVolume resources. | |||
| headers: | |||
| capacity: Capacity | |||
| access-modes: Access Mode | |||
There was a problem hiding this comment.
shouldn't it be "Access Modes"?
IwonaLanger
approved these changes
Sep 5, 2024
OliwiaGowor
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#2857
Definition of done
backlog#4567