Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change CRA to Vite #3334

Merged
merged 41 commits into from
Oct 8, 2024
Merged

chore: change CRA to Vite #3334

merged 41 commits into from
Oct 8, 2024

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Sep 8, 2024

Description

Changes proposed in this pull request:

  • migrate busola from Create React App to Vite
  • add config for vite
  • adjust jsonpath import import * as jp -> import jp
  • add plugins for SVG
  • add plugin viteTsConfigPath for absolut imports
  • uninstall react-scripts
  • adjust build command with NODE_OPTIONS
  • add favicons for page icon
  • fix data-testid

  • fix monaco console errors
  • adjust backend address for local Cypress run
  • adjust config files copy on build (resources validation)
  • bump Cypress version
  • chang import.meta.env.PUBLIC_URL to BASE_URL
  • adjustIS_DOCKER variable
  • temporarily adjusted Jest config (migration to Vitest will be followed in another PR)

Related issue(s)
Closes #3062

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2024
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mrCherry97 mrCherry97 changed the title chore: change CRS to Vite chore: change CRA to Vite Sep 8, 2024
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 8, 2024
Copy link
Contributor Author

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's left/need to be checked:

  • Cypress is working, but can't connect to the cluster (looks like frontend - backend connection is not working
  • Unit testes need to be adjusted (Jest and react-testing-library)
  • After running first time the app, there is some random refresh, need to be checked on the build version (run docker image from PR or npm run build && serve -d
  • monaco worker has some problem (need to be fixed or open an issue for follow up)
    image
  • need to run docker image from PR (local, web) and check that everything is working corectly

src/state/preferences/themeAtom.ts Outdated Show resolved Hide resolved
src/styles/index.scss Outdated Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
vite.config.mts Show resolved Hide resolved
@OliwiaGowor OliwiaGowor marked this pull request as ready for review October 2, 2024 06:11
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 2, 2024
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it looks good

package.json Show resolved Hide resolved
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 8, 2024
@kyma-bot kyma-bot merged commit 2f58885 into kyma-project:main Oct 8, 2024
18 checks passed
@mrCherry97 mrCherry97 deleted the vite-2 branch October 9, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. hacktoberfest hacktoberfest-accepted lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from create-react-app to Vite
5 participants