Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance events #3338

Merged
merged 3 commits into from
Sep 12, 2024
Merged

feat: enhance events #3338

merged 3 commits into from
Sep 12, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Sep 10, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • improved EventDetails (Metadata & Specification Panels)

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2024
@akucharska akucharska self-assigned this Sep 11, 2024
akucharska
akucharska requested changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@akucharska akucharska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move Involved Object and Source to Configuration Panel.

Add reportingComponent to Configuration Panel.

src/resources/Events/EventDetails.js Outdated
const { t } = useTranslation();

return (
<UI5Panel
key="message"
title={t('events.headers.message')}
title={t('common.headers.specification')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to ** Configuration** cause Events does not have Spec

@chriskari chriskari requested a review from a team as a code owner September 11, 2024 21:05
@OliwiaGowor OliwiaGowor mentioned this pull request Sep 10, 2024
Closed
58 tasks
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 12, 2024
@kyma-bot kyma-bot merged commit 3fcbdbb into kyma-project:main Sep 12, 2024
17 checks passed
@chriskari chriskari deleted the enhance-events branch October 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chriskari @akucharska @IwonaLanger @kyma-bot