Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enhance namespace overview #3342

Merged
merged 6 commits into from
Sep 16, 2024
Merged

feat: enhance namespace overview #3342

merged 6 commits into from
Sep 16, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Sep 12, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • added additional statistical cards to namespace overview
  • adjusted the all-namespaces overview

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 12, 2024
OliwiaGowor
OliwiaGowor reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@OliwiaGowor OliwiaGowor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking "Learn More" on counting card for Stateful Sets, Daemon Sets and Services on Namespace overview, always redirects to resource list with -all- namespaces selected, no matter what namespace you are currently on

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 16, 2024
@kyma-bot kyma-bot merged commit 79aacbc into kyma-project:main Sep 16, 2024
17 checks passed
@chriskari chriskari deleted the enhance-namespace-overview branch October 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chriskari @OliwiaGowor @kyma-bot