Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add overlays with environments configuration #3344

Merged
merged 3 commits into from
Sep 16, 2024
Merged

feat: Add overlays with environments configuration #3344

merged 3 commits into from
Sep 16, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Sep 13, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add environments overlays
  • Adjust the kustomize to new structure.

Related issue(s)
#3298

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2024
@dbadura dbadura mentioned this pull request Sep 13, 2024
Closed
11 tasks
@dbadura dbadura marked this pull request as ready for review September 13, 2024 13:19
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 16, 2024
@chriskari chriskari merged commit c2393c5 into kyma-project:main Sep 16, 2024
12 checks passed
@dbadura dbadura deleted the k8s-pick-env branch September 16, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskari chriskari chriskari approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbadura @kyma-bot @chriskari