Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape kebab case in jsonata expression #3348

Merged
merged 5 commits into from
Sep 18, 2024
Merged

fix: escape kebab case in jsonata expression #3348

merged 5 commits into from
Sep 18, 2024

Conversation

chriskari
Copy link
Contributor

@chriskari chriskari commented Sep 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@chriskari chriskari linked an issue Sep 16, 2024 that may be closed by this pull request
Details page fails to render spec fields with kebab-case #3127
Closed
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 18, 2024
@kyma-bot kyma-bot merged commit f84e7c4 into kyma-project:main Sep 18, 2024
17 checks passed
@chriskari chriskari deleted the fix-kebab-case branch October 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-kho kevin-kho kevin-kho left review comments

@akucharska akucharska akucharska approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@akucharska akucharska

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Details page fails to render spec fields with kebab-case
4 participants
@chriskari @kevin-kho @akucharska @kyma-bot