Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove capitalization of data in rows #3360

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix: Remove capitalization of data in rows #3360

merged 3 commits into from
Sep 24, 2024

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Sep 24, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • remove capitalization of data in rows
  • add option to enable capitalization

Related issue(s)
#3359

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@dbadura dbadura changed the title Remove capitalization of data in rows fix: Remove capitalization of data in rows Sep 24, 2024
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 24, 2024
@kyma-bot kyma-bot merged commit 74f8d03 into kyma-project:main Sep 24, 2024
17 checks passed
@dbadura dbadura deleted the remove-capitalize branch September 24, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbadura @OliwiaGowor @kyma-bot