Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: infinite loop when custom config.yaml is not available #3367

Closed
wants to merge 3 commits into from
Closed

fix: infinite loop when custom config.yaml is not available #3367

wants to merge 3 commits into from

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Sep 30, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • load config if it's yaml file

Related issue(s)
#3298

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2024
@dbadura dbadura mentioned this pull request Sep 30, 2024
Closed
11 tasks
@dbadura dbadura changed the title fix: Fix infinite loop when cusotm config.yaml is not available fix: fix infinite loop when cusotm config.yaml is not available Sep 30, 2024
@dbadura dbadura changed the title fix: fix infinite loop when cusotm config.yaml is not available fix: infinite loop when custom config.yaml is not available Sep 30, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2024
@dbadura dbadura closed this Oct 9, 2024
@dbadura dbadura deleted the fix-404 branch October 9, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees
No one assigned
Labels
cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbadura @kyma-bot