Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust spacing to classNames #3442

Merged
merged 13 commits into from
Nov 4, 2024
Merged

chore: adjust spacing to classNames #3442

merged 13 commits into from
Nov 4, 2024

Conversation

mrCherry97
Copy link
Contributor

Description

Changes proposed in this pull request:

  • ...
  • ...
  • ...

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 31, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review November 4, 2024 10:00
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@mrCherry97 mrCherry97 changed the title fix some imports to left only spacing chore: adjust spacing to classNames Nov 4, 2024
@mrCherry97 mrCherry97 mentioned this pull request Nov 4, 2024
Open
@OliwiaGowor OliwiaGowor self-assigned this Nov 4, 2024
OliwiaGowor
OliwiaGowor reviewed Nov 4, 2024
View reviewed changes
Copy link
Contributor

@OliwiaGowor OliwiaGowor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we use all of the replaced style props only for margins and paddings? So it can be safely replaced with only classNames or removed. Files:

  • SeparatorLine.js
  • DescriptionHint.tsx
  • ExternalLink.tsx
  • UI5Panel.tsx

src/components/BusolaExtensions/BusolaExtensionDetails.js Outdated
@@ -153,7 +152,7 @@ export function BusolaExtensionDetails({ name, namespace }) {
<MessageStrip
design="Information"
hideCloseButton
style={spacing.sapUiSmallMarginBottom}
className="sap-margin-bottom-small sap-margin-top-small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="sap-margin-bottom-small sap-margin-top-small"
className="sap-margin-y-small"

src/components/Clusters/components/AuthForm.js Outdated
@@ -129,7 +128,7 @@ export function AuthForm({
<MessageStrip
design="Warning"
hideCloseButton
style={spacing.sapUiSmallMarginTopBottom}
className="sap-margin-top-small sap-margin-bottom-small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="sap-margin-top-small sap-margin-bottom-small"
className="sap-margin-y-small"

src/components/Clusters/components/ClusterPreview.js Outdated
{t('clusters.wizard.review')}
</Title>
<Title
level="H5"
className="cluster-preview__subtitle"
style={spacing.sapUiSmallMarginTopBottom}
className="cluster-preview__subtitle sap-margin-top-small sap-margin-bottom-small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="cluster-preview__subtitle sap-margin-top-small sap-margin-bottom-small"
className="cluster-preview__subtitle sap-margin-y-small"

src/components/Clusters/components/ClusterPreview.js Outdated
@@ -153,17 +108,10 @@ export function ClusterPreview({ kubeconfig, storage, setSelected, hasAuth }) {
</div>
<Title
level="H5"
className="cluster-preview__subtitle"
style={spacing.sapUiSmallMarginTopBottom}
className="cluster-preview__subtitle sap-margin-top-small sap-margin-bottom-small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="cluster-preview__subtitle sap-margin-top-small sap-margin-bottom-small"
className="cluster-preview__subtitle sap-margin-y-small"

src/components/Clusters/components/ClusterPreview.js Outdated
@@ -177,25 +125,12 @@ export function ClusterPreview({ kubeconfig, storage, setSelected, hasAuth }) {
</div>
<Title
level="H5"
className="cluster-preview__subtitle"
style={spacing.sapUiSmallMarginTopBottom}
className="cluster-preview__subtitle sap-margin-top-small sap-margin-bottom-small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="cluster-preview__subtitle sap-margin-top-small sap-margin-bottom-small"
className="cluster-preview__subtitle sap-margin-y-small"

src/components/Clusters/components/ContextChooser/ContextChooser.js Outdated
@@ -63,7 +59,7 @@ export function ContextChooser(params) {
<MessageStrip
design="Information"
hideCloseButton
style={spacing.sapUiSmallMarginTopBottom}
className="sap-margin-top-small sap-margin-bottom-small"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className="sap-margin-top-small sap-margin-bottom-small"
className="sap-margin-y-small"

src/shared/components/ErrorBoundary/ErrorBoundary.js Outdated
className="bsl-color--text"
style={spacing.sapUiSmallMarginTopBottom}
>
<p className="bsl-color--text sap-margin-top-small sap-margin-bottom-small">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p className="bsl-color--text sap-margin-top-small sap-margin-bottom-small">
<p className="bsl-color--text sap-margin-y-small">

@mrCherry97
Copy link
Contributor Author

SeparatorLint - my mistake, it's adjusted
DescriptionHint.tsx - style prop is nowhere in use so that it could be removed
ExternalLink.tsx - iconStyle and linkStyle are adjusted everywhere to linkClassName and iconClassName
UI5Panel.tsx - style prop is nowhere in use so that it could be removed

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 4, 2024
@OliwiaGowor OliwiaGowor merged commit cd703c0 into kyma-project:ui5-migrate-v2 Nov 4, 2024
7 of 14 checks passed
@mrCherry97 mrCherry97 deleted the fix-spacing branch November 5, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrCherry97 @OliwiaGowor @kyma-bot