Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toast adjustments #3462

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: toast adjustments #3462

merged 1 commit into from
Nov 8, 2024

Conversation

mrCherry97
Copy link
Contributor

@mrCherry97 mrCherry97 commented Nov 8, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • fix: toast adjustments

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2024
@mrCherry97 mrCherry97 marked this pull request as ready for review November 8, 2024 08:37
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 8, 2024
@mrCherry97 mrCherry97 mentioned this pull request Nov 8, 2024
Open
@OliwiaGowor OliwiaGowor self-assigned this Nov 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 8, 2024
@OliwiaGowor OliwiaGowor merged commit 9c39bff into kyma-project:ui5-migrate-v2 Nov 8, 2024
26 of 63 checks passed
@mrCherry97 mrCherry97 deleted the fix-toasts branch November 8, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@akucharska akucharska Awaiting requested review from akucharska akucharska is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrCherry97 @OliwiaGowor @kyma-bot