Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compass Manager] The new URL to Compass System on DEV #92

Merged
merged 2 commits into from
Jan 23, 2024
Merged

[Compass Manager] The new URL to Compass System on DEV #92

merged 2 commits into from
Jan 23, 2024

Conversation

mvshao
Copy link
Contributor

@mvshao mvshao commented Jan 8, 2024

Description
CMP team are changing URLs, we need to align our components

Changes proposed in this pull request:

  • change the default (DEV) URL to Compass
  • CM will be using the new Compass secret (needs to be created by SRE)

Related issue(s)
#91

@mvshao mvshao added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2024
@mvshao mvshao requested a review from a team as a code owner January 8, 2024 12:21
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2024
@mvshao mvshao mentioned this pull request Jan 8, 2024
Closed
4 tasks
@mvshao mvshao changed the title The new URL to Compass System on DEV [Compass Manager] The new URL to Compass System on DEV Jan 8, 2024
@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 22, 2024
@mvshao mvshao removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2024
@kyma-bot kyma-bot merged commit b1cef59 into kyma-project:main Jan 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VOID404 VOID404 VOID404 approved these changes

Assignees

@VOID404 VOID404

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvshao @VOID404 @kyma-bot