Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple worker groups [KIM/feature] #46

Open
pbochynski opened this issue Sep 21, 2023 · 10 comments
Open

Multiple worker groups [KIM/feature] #46

pbochynski opened this issue Sep 21, 2023 · 10 comments
Labels
area/control-plane Related to all activities around Kyma Control Plane bv/functional-suitability Business Value: Functional Suitability (see ISO 25010) kind/feature Categorizes issue or PR as related to a new feature.

Comments

@pbochynski
Copy link
Contributor

pbochynski commented Sep 21, 2023

Description
Enable possibility to create multiple worker groups with different machine types, volume types, node labels, annotations, taints.

See Gardener specs:

Current example shoot from Provisioner:

 workers:
      - cri:
          name: containerd
        name: cpu-worker-0
        machine:
          type: m5.xlarge
          image:
            name: gardenlinux
            version: 1.2.3
          architecture: amd64
        maximum: 1
        minimum: 1
        maxSurge: 1
        maxUnavailable: 0
        volume:
          type: gp2
          size: 50Gi
        zones:
          - eu-central-1a
        systemComponents:
          allow: true
    workersSettings:
      sshAccess:
        enabled: true

Reasons
One size doesn't fit all. Many applications require specific nodes for particular services.

@pbochynski pbochynski added kind/feature Categorizes issue or PR as related to a new feature. area/control-plane Related to all activities around Kyma Control Plane Epic labels Sep 21, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tobiscr tobiscr removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 6, 2023
@tobiscr tobiscr reopened this Dec 6, 2023
@tobiscr
Copy link
Contributor

tobiscr commented Dec 6, 2023

@pbochynski : QQ - is this feature still relevant? If yes, I will start the alignment with KEB guys as it needs also their involvment.

@tobiscr tobiscr added bv/functional-suitability Business Value: Functional Suitability (see ISO 25010) and removed Epic labels Dec 18, 2023
@pbochynski
Copy link
Contributor Author

The issue is part of bigger Epic: kyma-project/kyma#18195

@tobiscr
Copy link
Contributor

tobiscr commented Mar 21, 2024

We agreed with @varbanv and @PK85 to start with a minimal worker pool configuration, probably similar to the parameter we are currently already providing to Google.

@tobiscr tobiscr changed the title Multiple worker groups [KIM/feature] Multiple worker groups Jun 26, 2024
@tobiscr tobiscr changed the title [KIM/feature] Multiple worker groups Multiple worker groups [KIM/feature] Jun 26, 2024
@tobiscr
Copy link
Contributor

tobiscr commented Jul 14, 2024

JFYI:

It's important to set

    systemComponents:
          allow: true

to ensure the pool-nodes gets a label which indicates the related worker pool. This is important for later scheduling rules (via affinity configurations etc.)


It worked also without systemComponents, see #364

@tobiscr
Copy link
Contributor

tobiscr commented Sep 23, 2024

To cover billing requirements, we have to extend the contract of the RuntimeCR with 2 new fields: kyma-project/kyma-metrics-collector#89

@tobiscr
Copy link
Contributor

tobiscr commented Sep 23, 2024

Today we aligned the next steps for rolling out multiple worker pools, and it makes sense to distinguish in the RuntimeCR between the Kyma worker pool (primarily used by Kyma workloads) and customer worker pools.

It's meaningful to reflect this differentiation also in the RuntimeCR by using a dedicated field for the Kyma worker pool and another field (array) for the customer worker pools.

Proposal:

  • workers field is used for describing the Kyma worker pool
  • additionalWorkers (new field) is an array describing the worker pools created by the customer

@tobiscr
Copy link
Contributor

tobiscr commented Sep 27, 2024

Requires #396

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Related to all activities around Kyma Control Plane bv/functional-suitability Business Value: Functional Suitability (see ISO 25010) kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants