Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with audit log extension comparison #489

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Fixed issue with audit log extension comparison #489

merged 2 commits into from
Nov 18, 2024

Conversation

akgalwas
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fixed raw extension matcher
  • Minor fix in error handling

@akgalwas akgalwas requested a review from a team as a code owner November 15, 2024 16:14
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2024
m00g3n
m00g3n approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 18, 2024
m00g3n
m00g3n approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 18, 2024
@kyma-bot kyma-bot merged commit 56d665b into kyma-project:main Nov 18, 2024
10 checks passed
@akgalwas akgalwas deleted the fix-audit-lo-matcher branch November 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

Assignees

@m00g3n m00g3n

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akgalwas @m00g3n @kyma-bot