Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Envoy global rate limit service #826

Closed
4 tasks done
Tracked by #1365
strekm opened this issue May 17, 2024 · 0 comments
Closed
4 tasks done
Tracked by #1365

[POC] Envoy global rate limit service #826

strekm opened this issue May 17, 2024 · 0 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@strekm
Copy link
Collaborator

strekm commented May 17, 2024

Description

Scope of this POC is to get to know possibilities and limitations of Envoy's global rate limit service. Use cases to cover are the same as in previous POC.

Envoy's global rate limit service supports 2 main methods of persistence: memcache and redis. Kyma does not offer in cluster Redis instance and in context of global rate limit Redis should be treated as dependency. In scope of this task explore external Redis support. Explore possibilities and limitations of both external Redis and memcached persistence methods.

Outcome should be documented.

Reasons

DoD:
- [ ] Provide unit and integration tests.

  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
    - [ ] If you changed the resource limits, explain why it was needed.
    - [ ] If the default configuration of Istio Operator has been changed, you performed a manual upgrade test to verify that the change can be rolled out correctly.
    - [ ] Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
    - [ ] Add release notes.

ACs:

  • evaluate external Redis
  • evaluate external Memcached

Attachments
https://github.com/envoyproxy/ratelimit?tab=readme-ov-file#memcache
part of: kyma-project/api-gateway#1365

@strekm strekm added the kind/feature Categorizes issue or PR as related to a new feature. label May 17, 2024
@barchw barchw assigned barchw and unassigned barchw May 27, 2024
@werdes72 werdes72 self-assigned this May 31, 2024
@werdes72 werdes72 removed their assignment Jun 17, 2024
@triffer triffer self-assigned this Jun 18, 2024
@werdes72 werdes72 assigned werdes72 and unassigned triffer and werdes72 Jun 20, 2024
@strekm strekm closed this as completed Jun 24, 2024
@strekm strekm mentioned this issue Jul 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants