Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit technical design #921

Closed
5 tasks done
strekm opened this issue Jul 4, 2024 · 0 comments
Closed
5 tasks done

Rate limit technical design #921

strekm opened this issue Jul 4, 2024 · 0 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@strekm
Copy link
Collaborator

strekm commented Jul 4, 2024

Description

Based on previous POCs and decision to support local rate limiting as part of Istio module provide technical design and API design. This should be focused on use case of local rate limiting but having in mind that later on global rate limiting might be introduced. Technical design should specify additional controller, still being part of Istio module, that will be listening to rate limit CRD.

Main scenario to cover with local rate limit is to protect a workload from overloading. It should be possible to configure number of requests per workload.

ACs:

  • technical design of rate limit functionality
  • API design for local rate limiting
  • above should be extensible to global rate limiting
  • ADR created

Reasons

DoD:
- [ ] Provide unit and integration tests.

  • Provide documentation.
    - [ ] Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
    - [ ] If you changed the resource limits, explain why it was needed.
    - [ ] If the default configuration of Istio Operator has been changed, you performed a manual upgrade test to verify that the change can be rolled out correctly.
    - [ ] Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
    - [ ] Add release notes.

Attachments
POCs: #774, #826
part of: kyma-project/api-gateway#1365

PR: #930

@strekm strekm added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 4, 2024
@kolodziejczak kolodziejczak self-assigned this Jul 5, 2024
@kolodziejczak kolodziejczak removed their assignment Jul 19, 2024
@triffer triffer assigned triffer and kolodziejczak and unassigned triffer Jul 22, 2024
@barchw barchw assigned nataliasitko and unassigned kolodziejczak Jul 24, 2024
@strekm strekm closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants