Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate limit technical design #930

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Rate limit technical design #930

merged 4 commits into from
Jul 24, 2024

Conversation

kolodziejczak
Copy link
Collaborator

@kolodziejczak kolodziejczak commented Jul 11, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Technical design of rate limit functionality
  • ADR
  • API design

Related issues

#921

@kolodziejczak kolodziejczak requested a review from a team as a code owner July 11, 2024 07:06
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2024
@kolodziejczak kolodziejczak marked this pull request as draft July 11, 2024 07:43
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 11, 2024
triffer
triffer reviewed Jul 11, 2024
View reviewed changes
docs/contributor/draft/rate-limit-api.yaml Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.yaml Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.yaml Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.yaml Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.yaml Outdated Show resolved Hide resolved
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2024
barchw
barchw previously requested changes Jul 15, 2024
View reviewed changes
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
@kolodziejczak kolodziejczak force-pushed the rate-limit-technical-design branch 2 times, most recently from 7ce0419 to 08c1d01 Compare July 16, 2024 06:43
triffer
triffer reviewed Jul 17, 2024
View reviewed changes
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-api.md Outdated Show resolved Hide resolved
@kolodziejczak kolodziejczak mentioned this pull request Jul 19, 2024
Closed
5 tasks
@kolodziejczak kolodziejczak changed the title Draft rate limit api Rate limit design Jul 19, 2024
@kolodziejczak kolodziejczak marked this pull request as ready for review July 22, 2024 05:28
@kolodziejczak kolodziejczak requested a review from a team as a code owner July 22, 2024 05:28
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2024
triffer
triffer reviewed Jul 22, 2024
View reviewed changes
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0007-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-design.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-design.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-design.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-design.md Outdated Show resolved Hide resolved
docs/contributor/draft/rate-limit-design.md Outdated Show resolved Hide resolved
@kyma-project kyma-project deleted a comment from triffer Jul 23, 2024
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 23, 2024
@kolodziejczak kolodziejczak changed the base branch from rate-limit-poc to main July 23, 2024 13:34
@kyma-bot kyma-bot removed the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 23, 2024
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 23, 2024
@kolodziejczak kolodziejczak changed the title Rate limit design Rate limit technical design Jul 23, 2024
@barchw barchw dismissed their stale review July 23, 2024 13:57

not needed

@kolodziejczak kolodziejczak added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2024
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 23, 2024
@triffer triffer self-requested a review July 24, 2024 06:13
triffer
triffer previously approved these changes Jul 24, 2024
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 24, 2024
@kolodziejczak kolodziejczak removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2024
nataliasitko
nataliasitko reviewed Jul 24, 2024
View reviewed changes
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
docs/contributor/adr/0008-rate-limit.md Outdated Show resolved Hide resolved
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jul 24, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 24, 2024
@kyma-bot kyma-bot merged commit ba1797e into kyma-project:main Jul 24, 2024
17 checks passed
@kolodziejczak kolodziejczak deleted the rate-limit-technical-design branch August 12, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barchw barchw barchw left review comments

@mluk-sap mluk-sap mluk-sap left review comments

@nataliasitko nataliasitko nataliasitko approved these changes

@triffer triffer triffer left review comments

Assignees

@triffer triffer

@nataliasitko nataliasitko

@barchw barchw

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kolodziejczak @triffer @mluk-sap @nataliasitko @barchw @kyma-bot