-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include breaking changes in release notes #1048
Open
nataliasitko
wants to merge
5
commits into
kyma-project:main
Choose a base branch
from
nataliasitko:include-breaking-changes-in-rns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Include breaking changes in release notes #1048
nataliasitko
wants to merge
5
commits into
kyma-project:main
from
nataliasitko:include-breaking-changes-in-rns
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Indicates the PR's author has signed the CLA.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Oct 1, 2024
nataliasitko
commented
Oct 1, 2024
kolodziejczak
requested changes
Oct 1, 2024
Co-authored-by: Marek Kołodziejczak <[email protected]>
kolodziejczak
changed the title
Include breaking chenges in release notes
Include breaking changes in release notes
Oct 1, 2024
kolodziejczak
requested changes
Oct 1, 2024
Comment on lines
+11
to
+13
has been updated to look for a semicolon to indicate the end of the cluster name. If you're using | ||
the `inbound_cluster_stat_name` or `outbound_cluster_stat_name` fields in meshconfig, the semicolon | ||
will be added automatically for you. If you have any dependency on the full stat name for cluster metrics, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
has been updated to look for a semicolon to indicate the end of the cluster name. If you're using | |
the `inbound_cluster_stat_name` or `outbound_cluster_stat_name` fields in meshconfig, the semicolon | |
will be added automatically for you. If you have any dependency on the full stat name for cluster metrics, | |
has been updated to look for a semicolon to indicate the end of the cluster name. If you have any dependency on the full stat name for cluster metrics, |
| **ENABLE_DELIMITED_STATS_TAG_REGEX** | `false` | | ||
| Name | Value | Description | | ||
|--------------------------------------|---------|-------------------------------------------------------------------------------------------------------------| | ||
| **ENABLE_DEFERRED_CLUSTER_CREATION** | `false` | Disables an experimental Envoy feature that optimizes Envoy configuration resources usage by inlining certain parts with already ongoing requests. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| **ENABLE_DEFERRED_CLUSTER_CREATION** | `false` | Disables an experimental Envoy feature that optimizes Envoy configuration resources usage by inlining certain parts with already ongoing requests. | | |
| **ENABLE_DEFERRED_CLUSTER_CREATION** | `false` | Disables an experimental Envoy feature that optimizes Envoy configuration by inlining certain steps with already ongoing requests. | |
- Update the Istio version to 1.23.2 [#1024](https://github.com/kyma-project/istio/pull/1024). Read [Istio 1.23.2 Release Announcement](https://istio.io/latest/news/releases/1.23.x/announcing-1.23.2/). | ||
- We've updated the Istio version to 1.23.2 ([#1024](https://github.com/kyma-project/istio/pull/1024)). Read Istio 1.23.2 [Release Announcement](https://istio.io/latest/news/releases/1.23.x/announcing-1.23.2/) and Istio 1.23.0 [Change Notes](https://istio.io/latest/news/releases/1.23.x/announcing-1.23/change-notes/). | ||
Take note of the following breaking changes included in the new minor version of Istio: | ||
- An experimental feature to enable cluster creation on worker threads inline during requests. This saves memory and CPU cycles in cases where there are lots of inactive clusters and more than one worker thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- An experimental feature to enable cluster creation on worker threads inline during requests. This saves memory and CPU cycles in cases where there are lots of inactive clusters and more than one worker thread. | |
- An experimental feature that enables more resource friendly propagation of the configuration within the Envoy worker threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Pre-Merge Checklist
Related issues