Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include breaking changes in release notes #1048

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nataliasitko
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Enhance release notes for Istio update and Compatibility mode documentation.

Pre-Merge Checklist

  • As a PR reviewer, verify code coverage and evaluate if it is acceptable.

Related issues

@nataliasitko nataliasitko requested a review from a team as a code owner October 1, 2024 09:25
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2024
docs/user/00-10-overview-istio-controller.md Outdated Show resolved Hide resolved
docs/user/00-10-overview-istio-controller.md Outdated Show resolved Hide resolved
docs/user/00-10-overview-istio-controller.md Outdated Show resolved Hide resolved
Co-authored-by: Marek Kołodziejczak <[email protected]>
@kolodziejczak kolodziejczak changed the title Include breaking chenges in release notes Include breaking changes in release notes Oct 1, 2024
Comment on lines +11 to +13
has been updated to look for a semicolon to indicate the end of the cluster name. If you're using
the `inbound_cluster_stat_name` or `outbound_cluster_stat_name` fields in meshconfig, the semicolon
will be added automatically for you. If you have any dependency on the full stat name for cluster metrics,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
has been updated to look for a semicolon to indicate the end of the cluster name. If you're using
the `inbound_cluster_stat_name` or `outbound_cluster_stat_name` fields in meshconfig, the semicolon
will be added automatically for you. If you have any dependency on the full stat name for cluster metrics,
has been updated to look for a semicolon to indicate the end of the cluster name. If you have any dependency on the full stat name for cluster metrics,

| **ENABLE_DELIMITED_STATS_TAG_REGEX** | `false` |
| Name | Value | Description |
|--------------------------------------|---------|-------------------------------------------------------------------------------------------------------------|
| **ENABLE_DEFERRED_CLUSTER_CREATION** | `false` | Disables an experimental Envoy feature that optimizes Envoy configuration resources usage by inlining certain parts with already ongoing requests. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| **ENABLE_DEFERRED_CLUSTER_CREATION** | `false` | Disables an experimental Envoy feature that optimizes Envoy configuration resources usage by inlining certain parts with already ongoing requests. |
| **ENABLE_DEFERRED_CLUSTER_CREATION** | `false` | Disables an experimental Envoy feature that optimizes Envoy configuration by inlining certain steps with already ongoing requests. |

- Update the Istio version to 1.23.2 [#1024](https://github.com/kyma-project/istio/pull/1024). Read [Istio 1.23.2 Release Announcement](https://istio.io/latest/news/releases/1.23.x/announcing-1.23.2/).
- We've updated the Istio version to 1.23.2 ([#1024](https://github.com/kyma-project/istio/pull/1024)). Read Istio 1.23.2 [Release Announcement](https://istio.io/latest/news/releases/1.23.x/announcing-1.23.2/) and Istio 1.23.0 [Change Notes](https://istio.io/latest/news/releases/1.23.x/announcing-1.23/change-notes/).
Take note of the following breaking changes included in the new minor version of Istio:
- An experimental feature to enable cluster creation on worker threads inline during requests. This saves memory and CPU cycles in cases where there are lots of inactive clusters and more than one worker thread.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- An experimental feature to enable cluster creation on worker threads inline during requests. This saves memory and CPU cycles in cases where there are lots of inactive clusters and more than one worker thread.
- An experimental feature that enables more resource friendly propagation of the configuration within the Envoy worker threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants