Apply markdowlint rules in the kyma repository #18621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for kyma-project pending review.Visit the deploys page to approve it
|
kyma-bot
added
cla: yes
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mmitoraj
previously approved these changes
Mar 20, 2024
|
Could you maybe add the new config files to the codeowner file, so that you are a defined owner of that |
|
@a-thaler |
a-thaler
reviewed
Mar 21, 2024
heading_capitalization.js
Outdated
| @@ -0,0 +1,28 @@ | |||
| module.exports = [{ | |||
There was a problem hiding this comment.
From where the file gets consumed? Is it picked up by naming convention? Could we maybe prefix it with something like ".markdown*" as well?
Could you at least put a comment in the file for what it is used
There was a problem hiding this comment.
I've changed the file name and added a comment.
a-thaler
approved these changes
Mar 21, 2024
mmitoraj
approved these changes
Mar 22, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See also #18497