Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply markdowlint rules in the kyma repository #18621

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

grego952
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Apply markdowlint rules in the kyma repository

Related issue(s)
See also #18497

@grego952 grego952 requested review from a team as code owners March 18, 2024 14:28
Copy link

netlify bot commented Mar 18, 2024

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a7d7db7

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit a7d7db7
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/65fbf773915fe00008ed141f
😎 Deploy Preview https://deploy-preview-18621--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mmitoraj
mmitoraj previously approved these changes Mar 20, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 20, 2024
@a-thaler
Copy link
Contributor

Could you maybe add the new config files to the codeowner file, so that you are a defined owner of that

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Mar 21, 2024
@grego952
Copy link
Contributor Author

@a-thaler
Thanks for pointing this out.
I've added TWs as codeowners and removed the milv.config.yaml file, as it was deleted some time ago already.

@@ -0,0 +1,28 @@
module.exports = [{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where the file gets consumed? Is it picked up by naming convention? Could we maybe prefix it with something like ".markdown*" as well?
Could you at least put a comment in the file for what it is used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the file name and added a comment.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 21, 2024
@kyma-bot kyma-bot merged commit 148ab08 into kyma-project:main Mar 22, 2024
9 checks passed
@grego952 grego952 deleted the markdown-linting branch March 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants